Clippy: don't bind unit values.

This commit is contained in:
Heiko Schaefer 2022-07-16 12:54:32 +02:00
parent d321fd22ac
commit f9ed6c30c0
No known key found for this signature in database
GPG key ID: 4A849A1904CCBD7D
2 changed files with 7 additions and 7 deletions

View file

@ -76,7 +76,7 @@ impl<'a> Open<'a> {
} }
pub fn verify_user(&mut self, pin: &[u8]) -> Result<(), Error> { pub fn verify_user(&mut self, pin: &[u8]) -> Result<(), Error> {
let _ = self.opt.verify_pw1_user(pin)?; self.opt.verify_pw1_user(pin)?;
self.pw1 = true; self.pw1 = true;
Ok(()) Ok(())
} }
@ -84,13 +84,13 @@ impl<'a> Open<'a> {
pub fn verify_user_pinpad(&mut self, pinpad_prompt: &dyn Fn()) -> Result<(), Error> { pub fn verify_user_pinpad(&mut self, pinpad_prompt: &dyn Fn()) -> Result<(), Error> {
pinpad_prompt(); pinpad_prompt();
let _ = self.opt.verify_pw1_user_pinpad()?; self.opt.verify_pw1_user_pinpad()?;
self.pw1 = true; self.pw1 = true;
Ok(()) Ok(())
} }
pub fn verify_user_for_signing(&mut self, pin: &[u8]) -> Result<(), Error> { pub fn verify_user_for_signing(&mut self, pin: &[u8]) -> Result<(), Error> {
let _ = self.opt.verify_pw1_sign(pin)?; self.opt.verify_pw1_sign(pin)?;
// FIXME: depending on card mode, pw1_sign is only usable once // FIXME: depending on card mode, pw1_sign is only usable once
@ -104,7 +104,7 @@ impl<'a> Open<'a> {
) -> Result<(), Error> { ) -> Result<(), Error> {
pinpad_prompt(); pinpad_prompt();
let _ = self.opt.verify_pw1_sign_pinpad()?; self.opt.verify_pw1_sign_pinpad()?;
// FIXME: depending on card mode, pw1_sign is only usable once // FIXME: depending on card mode, pw1_sign is only usable once
@ -113,7 +113,7 @@ impl<'a> Open<'a> {
} }
pub fn verify_admin(&mut self, pin: &[u8]) -> Result<(), Error> { pub fn verify_admin(&mut self, pin: &[u8]) -> Result<(), Error> {
let _ = self.opt.verify_pw3(pin)?; self.opt.verify_pw3(pin)?;
self.pw3 = true; self.pw3 = true;
Ok(()) Ok(())
} }
@ -121,7 +121,7 @@ impl<'a> Open<'a> {
pub fn verify_admin_pinpad(&mut self, pinpad_prompt: &dyn Fn()) -> Result<(), Error> { pub fn verify_admin_pinpad(&mut self, pinpad_prompt: &dyn Fn()) -> Result<(), Error> {
pinpad_prompt(); pinpad_prompt();
let _ = self.opt.verify_pw3_pinpad()?; self.opt.verify_pw3_pinpad()?;
self.pw3 = true; self.pw3 = true;
Ok(()) Ok(())
} }

View file

@ -254,7 +254,7 @@ impl<'a> OpenPgpTransaction<'a> {
// Possible response data (Control Parameter = CP) don't need to be evaluated by the // Possible response data (Control Parameter = CP) don't need to be evaluated by the
// application (See "7.2.5 SELECT DATA") // application (See "7.2.5 SELECT DATA")
let _ = apdu::send_command(self.tx(), cmd, true)?.try_into()?; apdu::send_command(self.tx(), cmd, true)?.try_into()?;
Ok(()) Ok(())
} }