turnkey/openpgp-card
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

openpgp-card-sequoia: Login Data is a binary field

Browse source
This commit is contained in:
Heiko Schaefer 2023-09-04 09:10:01 +02:00
parent 1de083e1b8
commit f7936a75fd
No known key found for this signature in database
GPG key ID: 4A849A1904CCBD7D
2 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
card-functionality/src/tests.rs
View file

@ -357,12 +357,12 @@ pub fn test_set_login_data(
let mut admin = tx.to_admin_card("12345678")?; let mut admin = tx.to_admin_card("12345678")?;
let test_login = "someone@somewhere.com"; let test_login = "someone@somewhere.com";
admin.set_login_data(test_login)?; admin.set_login_data(test_login.as_bytes())?;
// Read the previously set login data // Read the previously set login data
let read_login_data = tx.login_data()?; let read_login_data = tx.login_data()?;
assert_eq!(read_login_data, test_login); assert_eq!(&read_login_data, test_login.as_bytes());
Ok(vec![]) Ok(vec![])
} }

15
openpgp-card-sequoia/src/lib.rs
View file

@ -555,9 +555,14 @@ impl<'a> Card<Transaction<'a>> {
// --- optional private DOs (0101 - 0104) --- // --- optional private DOs (0101 - 0104) ---
// --- login data (5e) --- /// Login Data
pub fn login_data(&mut self) -> Result<String, Error> { ///
Ok(String::from_utf8_lossy(&self.state.opt.login_data()?).to_string()) /// This DO can be used to store any information used for the Log-In
/// process in a client/server authentication (e.g. user name of a
/// network).
/// The maximum length of this DO is announced in Extended Capabilities.
pub fn login_data(&mut self) -> Result<Vec<u8>, Error> {
self.state.opt.login_data()
} }
// --- URL (5f50) --- // --- URL (5f50) ---
@ -893,8 +898,8 @@ impl Card<Admin<'_, '_>> {
self.card().set_sex(sex) self.card().set_sex(sex)
} }
pub fn set_login_data(&mut self, login_data: &str) -> Result<(), Error> { pub fn set_login_data(&mut self, login_data: &[u8]) -> Result<(), Error> {
self.card().set_login(login_data.as_bytes()) self.card().set_login(login_data)
} }
/// Set "hardholder" URL on the card. /// Set "hardholder" URL on the card.