turnkey/openpgp-card
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

workaround and test for "ledger nano s" quirks

Browse source
This commit is contained in:
Heiko Schaefer 2022-01-25 13:01:15 +01:00
parent 9cdc699745
commit 40f279684e
No known key found for this signature in database
GPG key ID: 4A849A1904CCBD7D
1 changed files with 43 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
openpgp-card/src/card_do/historical.rs
View file

@ -80,7 +80,17 @@ impl HistoricalBytes {
impl TryFrom<&[u8]> for HistoricalBytes {
type Error = Error;
fn try_from(data: &[u8]) -> Result<Self, Self::Error> {
fn try_from(mut data: &[u8]) -> Result<Self, Self::Error> {
// workaround-hack for "ledger" with zero-padded historical bytes
if data.ends_with(&[0x90, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0]) {
data = data.strip_suffix(&[0x0, 0x0, 0x0, 0x0, 0x0]).unwrap();
}
// workaround-hack for "ledger": fix status indicator byte 7
if data == &[0x0, 0x31, 0xc5, 0x73, 0xc0, 0x1, 0x80, 0x7, 0x90, 0x0] {
data = &[0x0, 0x31, 0xc5, 0x73, 0xc0, 0x1, 0x80, 0x5, 0x90, 0x0];
}
let len = data.len();
if len < 4 {
@ -341,4 +351,36 @@ mod test {
Ok(())
}
#[test]
fn test_ledger_nano_s() -> Result<()> {
let data: &[u8] = &[
0x0, 0x31, 0xc5, 0x73, 0xc0, 0x1, 0x80, 0x7, 0x90, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0,
];
let hist: HistoricalBytes = data.try_into()?;
assert_eq!(
hist,
HistoricalBytes {
cib: 0,
csd: Some(CardServiceData {
select_by_full_df_name: true,
select_by_partial_df_name: true,
dos_available_in_ef_dir: false,
dos_available_in_ef_atr_info: false,
access_services: [false, true, false],
mf: true
}),
cc: Some(CardCapabilities {
command_chaining: true,
extended_lc_le: false,
extended_length_information: false
}),
sib: 5
}
);
Ok(())
}
}