diff --git a/openpgp-card-sequoia/src/decryptor.rs b/openpgp-card-sequoia/src/decryptor.rs index bd73f0b..8b92a75 100644 --- a/openpgp-card-sequoia/src/decryptor.rs +++ b/openpgp-card-sequoia/src/decryptor.rs @@ -79,17 +79,17 @@ impl<'a> crypto::Decryptor for CardDecryptor<'a> { &self.public } - /// Delegate a decryption operation to the OpenPGP card. - /// - /// This fn prepares the data structures that openpgp-card needs to - /// perform the decryption operation. - /// - /// (7.2.11 PSO: DECIPHER) fn decrypt( &mut self, ciphertext: &mpi::Ciphertext, _plaintext_len: Option, ) -> openpgp::Result { + /// Delegate a decryption operation to the OpenPGP card. + /// + /// This fn prepares the data structures that openpgp-card needs to + /// perform the decryption operation. + /// + /// (7.2.11 PSO: DECIPHER) match (ciphertext, self.public.mpis()) { (mpi::Ciphertext::RSA { c: ct }, mpi::PublicKey::RSA { .. }) => { let dm = Cryptogram::RSA(ct.value()); diff --git a/openpgp-card-sequoia/src/sq_util.rs b/openpgp-card-sequoia/src/sq_util.rs index f018400..eec566a 100644 --- a/openpgp-card-sequoia/src/sq_util.rs +++ b/openpgp-card-sequoia/src/sq_util.rs @@ -1,7 +1,9 @@ // SPDX-FileCopyrightText: 2021 Heiko Schaefer // SPDX-License-Identifier: MIT OR Apache-2.0 -//! Simple wrappers for performing very specific tasks with Sequoia PGP +//! Simple wrappers for performing very specific tasks with Sequoia PGP. +//! +//! These helpers are (almost) entirely unrelated to OpenPGP Card. use anyhow::{anyhow, Context, Result}; use std::io; diff --git a/openpgp-card-sequoia/src/util.rs b/openpgp-card-sequoia/src/util.rs index 009a6ad..e618c06 100644 --- a/openpgp-card-sequoia/src/util.rs +++ b/openpgp-card-sequoia/src/util.rs @@ -38,6 +38,8 @@ use crate::{decryptor, signer, PublicKey}; /// Create a Cert from the three subkeys on a card. /// (Calling this multiple times will result in different Certs!) /// +/// FIXME: contains hardcoded default passwords! +/// /// FIXME: make dec/auth keys optional /// /// FIXME: accept optional metadata for user_id(s)?