turnkey/openpgp-card
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

In key generation: don't set algo attributes if the card doesn't support that feature.

Browse source
This commit is contained in:
Heiko Schaefer 2021-09-17 13:56:28 +02:00
parent a39f25d8a3
commit 0bf59c7e51
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
openpgp-card/src/keys.rs
View file

@ -42,8 +42,16 @@ pub(crate) fn gen_key_with_metadata(
) -> Result<(PublicKeyMaterial, KeyGenerationTime), Error> { ) -> Result<(PublicKeyMaterial, KeyGenerationTime), Error> {
// set algo on card if it's Some // set algo on card if it's Some
if let Some(algo) = algo { if let Some(algo) = algo {
// only set algo if card supports setting of algo attr
// FIXME: caching
let ard = card_app.get_application_related_data()?;
let ecap = ard.get_extended_capabilities()?;
if ecap.algo_attrs_changeable() {
card_app.set_algorithm_attributes(key_type, algo)?; card_app.set_algorithm_attributes(key_type, algo)?;
} }
}
// algo // algo
let ard = card_app.get_application_related_data()?; // no caching, here! let ard = card_app.get_application_related_data()?; // no caching, here!