turnkey/openpgp-card
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add notes that "check_pw1 causes the error counter to decrease" (see #23) on some cards

Browse source
This commit is contained in:
Heiko Schaefer 2022-02-21 17:22:18 +01:00
parent 12a6a77b8d
commit 074bab321e
No known key found for this signature in database
GPG key ID: 4A849A1904CCBD7D
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
openpgp-card/src/lib.rs
View file

@ -431,8 +431,10 @@ pub trait CardTransaction {
/// ///
/// If verification is not required, an empty Ok Response is returned. /// If verification is not required, an empty Ok Response is returned.
/// ///
/// (Note: some cards don't correctly implement this feature, /// (Note:
/// e.g. YubiKey 5) /// - some cards don't correctly implement this feature, e.g. YubiKey 5
/// - some cards that don't support this instruction may decrease the pin's error count,
/// eventually requiring the user to reset the pin)
fn check_pw1_for_signing(&mut self) -> Result<(), Error> { fn check_pw1_for_signing(&mut self) -> Result<(), Error> {
let verify = commands::verify_pw1_81(vec![]); let verify = commands::verify_pw1_81(vec![]);
apdu::send_command(self, verify, false)?.try_into() apdu::send_command(self, verify, false)?.try_into()
@ -459,8 +461,10 @@ pub trait CardTransaction {
/// ///
/// If verification is not required, an empty Ok Response is returned. /// If verification is not required, an empty Ok Response is returned.
/// ///
/// (Note: some cards don't correctly implement this feature, /// (Note:
/// e.g. YubiKey 5) /// - some cards don't correctly implement this feature, e.g. YubiKey 5
/// - some cards that don't support this instruction may decrease the pin's error count,
/// eventually requiring the user to reset the pin)
fn check_pw1(&mut self) -> Result<(), Error> { fn check_pw1(&mut self) -> Result<(), Error> {
let verify = commands::verify_pw1_82(vec![]); let verify = commands::verify_pw1_82(vec![]);
apdu::send_command(self, verify, false)?.try_into() apdu::send_command(self, verify, false)?.try_into()
@ -483,8 +487,10 @@ pub trait CardTransaction {
/// ///
/// If verification is not required, an empty Ok Response is returned. /// If verification is not required, an empty Ok Response is returned.
/// ///
/// (Note: some cards don't correctly implement this feature, /// (Note:
/// e.g. YubiKey 5) /// - some cards don't correctly implement this feature, e.g. YubiKey 5
/// - some cards that don't support this instruction may decrease the pin's error count,
/// eventually requiring the user to reset the pin)
fn check_pw3(&mut self) -> Result<(), Error> { fn check_pw3(&mut self) -> Result<(), Error> {
let verify = commands::verify_pw3(vec![]); let verify = commands::verify_pw3(vec![]);
apdu::send_command(self, verify, false)?.try_into() apdu::send_command(self, verify, false)?.try_into()