turnkey/openpgp-card
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

openpgp-card: don't PUT algorithm_attributes if feature is unsupported

Browse source 
And improve rustdocs.
This commit is contained in:
Heiko Schaefer 2023-08-31 12:24:52 +02:00
parent b1c4b46b22
commit 0067fe1d48
No known key found for this signature in database
GPG key ID: 4A849A1904CCBD7D
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
openpgp-card/src/lib.rs
View file

@ -1103,17 +1103,32 @@ impl<'a> Transaction<'a> {
self.send_command(cmd, false)?.try_into() self.send_command(cmd, false)?.try_into()
} }
/// Set algorithm attributes /// Set algorithm attributes for a key slot (4.4.3.9 Algorithm Attributes)
/// (4.4.3.9 Algorithm Attributes) ///
/// Note: `algorithm_attributes` needs to precisely specify the
/// RSA bit-size of e (if applicable), and import format, with values
/// that the current card supports.
pub fn set_algorithm_attributes( pub fn set_algorithm_attributes(
&mut self, &mut self,
key_type: KeyType, key_type: KeyType,
algo: &AlgorithmAttributes, algorithm_attributes: &AlgorithmAttributes,
) -> Result<(), Error> { ) -> Result<(), Error> {
log::info!("OpenPgpTransaction: set_algorithm_attributes"); log::info!("OpenPgpTransaction: set_algorithm_attributes");
// Don't set algorithm if the feature is not available?
let ecap = self.extended_capabilities()?;
if !ecap.algo_attrs_changeable() {
// Don't change the algorithm attributes, if the card doesn't support change
// FIXME: Compare current and requested setting and return an error, if they differ?
return Ok(());
}
// Command to PUT the algorithm attributes // Command to PUT the algorithm attributes
let cmd = commands::put_data(key_type.algorithm_tag(), algo.to_data_object()?); let cmd = commands::put_data(
key_type.algorithm_tag(),
algorithm_attributes.to_data_object()?,
);
self.send_command(cmd, false)?.try_into() self.send_command(cmd, false)?.try_into()
} }